-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic language and script fallback for the Android backend. #29
Conversation
This suffers from limitations in the other fallback code, namely that |
I went ahead and added a workaround that checks if some |
One of the limitations of this is that it only functions when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know enough about what you're actually doing here, but I know enough to spot a typo!
I'd be happy to test this on my device if there's a procedure for that, but I don't have the expertise to work out what's happening very quickly, and so could only give a rubber stamping review. In which case, it should probably be given by Chad. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing obviously entirely broken in the Rust code. Hopefully this behaviour will be fully covered in tests once we add those...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I think most of the logic here can be vastly simplified by just using the existing FallbackMap
type which already handles most of the locale mapping internally. I don’t mind landing this as-is as an intermediate step though if it keeps things moving.
There is https://github.com/xorgy/xilem/tree/andtaffy if you have a local parley hooked up in the Cargo.toml. I primarily test this stuff on desktop (you just need to swap the |
9884d7b
to
c29ae9f
Compare
No description provided.